mupdf: 1.23.6 -> 1.24.0; pymupdf: 1.23.16 -> 1.24.0 #298978
Closed
thiagokokada wants to merge 2 commits intoNixOS:stagingfrom
Closed
mupdf: 1.23.6 -> 1.24.0; pymupdf: 1.23.16 -> 1.24.0 #298978thiagokokada wants to merge 2 commits intoNixOS:stagingfrom
thiagokokada wants to merge 2 commits intoNixOS:stagingfrom
Conversation
Contributor
Author
|
@ofborg build mupdf mupdf.passthru.tests |
Member
|
@dotlambda opened this #298783 |
dotlambda
reviewed
Mar 25, 2024
|
|
||
| let | ||
|
|
||
| freeglut-mupdf = freeglut.overrideAttrs (old: rec { |
Member
There was a problem hiding this comment.
I'd be happy to remove this in my PR as well. What made you remove it?
Contributor
Author
There was a problem hiding this comment.
The repository was not updated in 3 years, so I want to know if this is really necessary or not.
Contributor
Author
There was a problem hiding this comment.
Looking at the Arch package, they seem to be using freeglut from upstream too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replacement PR for:
Fix
pymupdfbuild since it is currently broken inmaster.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.