Skip to content

mupdf: 1.23.6 -> 1.24.0; pymupdf: 1.23.16 -> 1.24.0 #298978

Closed
thiagokokada wants to merge 2 commits intoNixOS:stagingfrom
thiagokokada:bump-mupdf
Closed

mupdf: 1.23.6 -> 1.24.0; pymupdf: 1.23.16 -> 1.24.0 #298978
thiagokokada wants to merge 2 commits intoNixOS:stagingfrom
thiagokokada:bump-mupdf

Conversation

@thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Mar 25, 2024

Description of changes

Replacement PR for:

Fix pymupdf build since it is currently broken in master.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 25, 2024
@thiagokokada
Copy link
Contributor Author

@ofborg build mupdf mupdf.passthru.tests

@Aleksanaa
Copy link
Member

@dotlambda opened this #298783


let

freeglut-mupdf = freeglut.overrideAttrs (old: rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to remove this in my PR as well. What made you remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repository was not updated in 3 years, so I want to know if this is really necessary or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Arch package, they seem to be using freeglut from upstream too.

@thiagokokada thiagokokada deleted the bump-mupdf branch March 25, 2024 18:48
@ofborg ofborg bot requested review from fpletz, lilyinstarlight, teto and vrthra March 25, 2024 18:58
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants